Skip to content

[stable-3.10] Fix #5213 app is excluded from recent/current apps#5324

Merged
AndyScherzinger merged 1 commit into
stable-3.10from
backport/5218/stable-3.10
Jan 27, 2020
Merged

[stable-3.10] Fix #5213 app is excluded from recent/current apps#5324
AndyScherzinger merged 1 commit into
stable-3.10from
backport/5218/stable-3.10

Conversation

@backportbot-nextcloud

@backportbot-nextcloud backportbot-nextcloud Bot commented Jan 27, 2020

Copy link
Copy Markdown

backport of #5218

@backportbot-nextcloud backportbot-nextcloud Bot added this to the Nextcloud App 3.10.1 milestone Jan 27, 2020
@backportbot-nextcloud backportbot-nextcloud Bot mentioned this pull request Jan 27, 2020
Merged
@nextcloud-android-bot

nextcloud-android-bot commented Jan 27, 2020

Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12415.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

nextcloud-android-bot commented Jan 27, 2020

Copy link
Copy Markdown
Collaborator

Lint

Typestable-3.10PR
Warnings7676
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings138
Total413

SpotBugs (stable-3.10)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings138
Total413

@codecov

codecov Bot commented Jan 27, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5324 into stable-3.10 will increase coverage by 0.04%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             stable-3.10   #5324      +/-   ##
================================================
+ Coverage          17.65%   17.7%   +0.04%     
  Complexity             3       3              
================================================
  Files                392     392              
  Lines              33142   33140       -2     
  Branches            4657    4656       -1     
================================================
+ Hits                5851    5866      +15     
+ Misses             26338   26313      -25     
- Partials             953     961       +8
Impacted Files Coverage Δ Complexity Δ
...com/owncloud/android/ui/activity/BaseActivity.java 38.46% <ø> (+0.82%) 0 <0> (ø) ⬇️
...om/owncloud/android/utils/FileSortOrderByName.java 14.28% <0%> (-2.86%) 0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java 65.92% <0%> (-1.77%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java 24.89% <0%> (-0.85%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 31.56% <0%> (-0.73%) 0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java 58.94% <0%> (-0.41%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 26.31% <0%> (ø) 0% <0%> (ø) ⬇️
...cloud/android/ui/activity/FileDisplayActivity.java 20.44% <0%> (+0.39%) 0% <0%> (ø) ⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java 50.76% <0%> (+1.92%) 0% <0%> (ø) ⬇️
...m/owncloud/android/ui/activity/DrawerActivity.java 45.48% <0%> (+2.64%) 0% <0%> (ø) ⬇️

@AndyScherzinger
AndyScherzinger merged commit 4b2a033 into stable-3.10 Jan 27, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the backport/5218/stable-3.10 branch January 27, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes
@JorisBodin JorisBodin Awaiting requested review from JorisBodin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud App 3.10.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nextcloud-android-bot @tobiasKaminsky @AndyScherzinger @JorisBodin